Skip to content

Conversation

@jkoritzinsky
Copy link
Member

This explicitly doesn't touch ItemsToPushToBlobFeed as that item group is undocumented and Artifact items with SkipPublish=true don't even make it into ItemsToPushToBlobFeed, so we'd have to remove items instead, which doesn't give a good user gesture to force publishing wixpacks anyway for some reason.

To double check:

This explicitly doesn't touch ItemsToPushToBlobFeed as that item group is undocumented and Artifact items with SkipPublish=true don't even make it into ItemsToPushToBlobFeed, so we'd have to remove items instead, which doesn't give a good user gesture to force publishing wixpacks anyway for some reason.
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have my reservations with this change. The SkipPublish metadata was only added so that all artifact items could be defined in a single place in Sign.proj, even ones that should only be signed but not published. I want to remove that metadata again. I should have used other repo local means to achieve that.

We will eventually update the default artifact globs in Arcade to include zips and will then make sure that wixpack.zip files aren't included.

Until then, I'm ok with this change as the plan is to remove the Artifact extension point anyway.

@jkoritzinsky
Copy link
Member Author

I do personally prefer the Artifact item group more than the ItemsToSign and ItemsToPushToBlobFeed item groups, especially as ItemsToPushToBlobFeed items aren't always pushed to feeds any more, but that's a discussion for another day.

@jkoritzinsky jkoritzinsky merged commit 6aa6da5 into dotnet:main Jan 28, 2025
11 checks passed
@jkoritzinsky jkoritzinsky deleted the wixpack-no-publish-by-default branch January 28, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants