Update docs with new information #15460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
premun
reviewed
Jan 28, 2025
| - `eng/common` is mapped from Arcade into VMR's root (and also mirrored to `src/arcade/eng/common`). | ||
| - Changes of `eng/common` in the VMR are only allowed when also changing Arcade's ❓❓❓. | ||
| - When code is flowing from arcade to the VMR, we treat it as any other code flow subscription, and just update `src/arcade`. | ||
| - Changes of `eng/common` in the VMR`s root are **not** allowed. |
Member
There was a problem hiding this comment.
Technically they are allowed but will be overwritten like in any other repo
| arcade->>VMR: Forward flow to VMR | ||
| activate VMR | ||
| Note over VMR: eng/common is copied to:<br>src/arcade/eng/common<br>and eng/common | ||
| Note over VMR: eng/common is copied to:<br>src/arcade/eng/common |
Member
There was a problem hiding this comment.
This is misleading. Of course it gets copied there because the whole src/arcade folder goes in there.
Though it does not get copied but code-flown (so regular source code flow).
Member
Author
There was a problem hiding this comment.
I deleted the whole note since it doesn't behave special in any way
dkurepa
commented
Jan 30, 2025
Co-authored-by: Přemek Vysoký <[email protected]>
Co-authored-by: Přemek Vysoký <[email protected]>
premun
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To double check:
Handle
eng/commonfiles during code flow updates arcade-services#4253