Skip to content

Update to RoslynTools.MSBuild 17.12.0#15423

Merged
chcosta merged 1 commit into
dotnet:release/8.0from
chcosta:dev/chcosta/roslyntools.msbuild.17.12.0
Jan 16, 2025
Merged

Update to RoslynTools.MSBuild 17.12.0#15423
chcosta merged 1 commit into
dotnet:release/8.0from
chcosta:dev/chcosta/roslyntools.msbuild.17.12.0

Conversation

@chcosta

@chcosta chcosta commented Jan 16, 2025

Copy link
Copy Markdown
Member

Update release/8.0 to RoslynTools.MSBuild 17.12.0

Repackages Microsoft.DotNet.Arcade.MSBuild.Xcopy as RoslynTools.MSBuild to be compatible with the package naming conventions expected in release/8.0.

This unblocks the dotnet/maintenance-packages repo builds.

Validated with https://dev.azure.com/dnceng/internal/_build/results?buildId=2622148&view=results

To double check:

@rainersigwald rainersigwald left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I did not independently validate functionality).

@carlossanlop

carlossanlop commented Jan 16, 2025

Copy link
Copy Markdown
Contributor

LGTM (I did not independently validate functionality).

Let me test it here: dotnet/maintenance-packages#195

@carlossanlop

Copy link
Copy Markdown
Contributor

@chcosta ran a build in the internal azdo maintenance-packages branch including these changes and it passed. 🎉

@chcosta, please do the honors and smash that squash&merge button! 😄

@chcosta chcosta merged commit 4db7252 into dotnet:release/8.0 Jan 16, 2025
@chcosta chcosta deleted the dev/chcosta/roslyntools.msbuild.17.12.0 branch January 16, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants