Remove signing information from the build manifest models#15415
Merged
mmitche merged 4 commits intodotnet:mainfrom Jan 16, 2025
Merged
Remove signing information from the build manifest models#15415mmitche merged 4 commits intodotnet:mainfrom
mmitche merged 4 commits intodotnet:mainfrom
Conversation
Member
Author
|
Thoughts on this Viktor? |
Member
|
Yes, this is a good change. Thoughts on stop importing Sign.props in Publish.proj eventually? (not as part of this change as repos would need to react to it) |
ViktorHofer
previously approved these changes
Jan 15, 2025
Member
ViktorHofer
left a comment
ViktorHofer
left a comment
There was a problem hiding this comment.
If I read this correctly /p:Sign=false, not passing the -sing flag in or /p:PostBuildSign=true now all do more or less the same thing. They skip signing.
Is that correct?
Member
Author
Correct. PostBuildSign=true is the next thing to remove, but needs changes in the repos so that they don't sign if not desired. |
Member
Author
|
Fixed up tests. PTAL |
ViktorHofer
approved these changes
Jan 16, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To double check: