Use Core MSBuild to run MicroBuild in SignTool#15398
Use Core MSBuild to run MicroBuild in SignTool#15398ellahathaway merged 2 commits intodotnet:mainfrom
Conversation
ViktorHofer
left a comment
There was a problem hiding this comment.
Another desktop msbuild requirement hits the dust. Perfect 👍
|
@ellahathaway You may want to verify that roslyn's signing works properly with this change. IIRC, there are a few features (VSIX signing?) that are disabled except under framework. Those may be artificial restrictions these days, stemming from the days when Microbuild didn't work on Core, but we should verify. |
Can do. I'll rerun my VMR test build and then compare the signed roslyn artifacts between the core and desktop msbuild versions. Edit: Will run roslyn's official pipeline |
|
Discussed offline with @mmitche that this change only affects running MicroBuild with SignTool. Therefore, verifying a few SignTool features that are disabled except under the framework is unnecessary. In other words, verification would be required if SignTool itself had to be invoked with core msbuild, but this change is only for running MicroBuild commands within SignTool. |
Closes #15046
Ran arcade's unit tests and did local e2e testing on Windows with arcade-validation & a local arcade package's feed.
VMR test run (manually cancelled after a few successful repo builds completed)