Skip to content

Use Core MSBuild to run MicroBuild in SignTool#15398

Merged
ellahathaway merged 2 commits intodotnet:mainfrom
ellahathaway:windows-netcore
Jan 14, 2025
Merged

Use Core MSBuild to run MicroBuild in SignTool#15398
ellahathaway merged 2 commits intodotnet:mainfrom
ellahathaway:windows-netcore

Conversation

@ellahathaway
Copy link
Member

@ellahathaway ellahathaway commented Jan 10, 2025

Closes #15046

Ran arcade's unit tests and did local e2e testing on Windows with arcade-validation & a local arcade package's feed.

VMR test run (manually cancelled after a few successful repo builds completed)

@ellahathaway ellahathaway requested a review from mmitche January 10, 2025 21:21
@ellahathaway ellahathaway marked this pull request as ready for review January 10, 2025 21:21
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another desktop msbuild requirement hits the dust. Perfect 👍

@mmitche
Copy link
Member

mmitche commented Jan 13, 2025

@ellahathaway You may want to verify that roslyn's signing works properly with this change. IIRC, there are a few features (VSIX signing?) that are disabled except under framework. Those may be artificial restrictions these days, stemming from the days when Microbuild didn't work on Core, but we should verify.

@ellahathaway
Copy link
Member Author

ellahathaway commented Jan 13, 2025

You may want to verify that roslyn's signing works properly with this change. IIRC, there are a few features (VSIX signing?) that are disabled except under framework

Can do. I'll rerun my VMR test build and then compare the signed roslyn artifacts between the core and desktop msbuild versions.

Edit: Will run roslyn's official pipeline

@ellahathaway ellahathaway changed the title Use Core MSBuild on Windows Use Core MSBuild to run MicroBuild in SignTool Jan 13, 2025
@ellahathaway
Copy link
Member Author

Discussed offline with @mmitche that this change only affects running MicroBuild with SignTool. Therefore, verifying a few SignTool features that are disabled except under the framework is unnecessary. In other words, verification would be required if SignTool itself had to be invoked with core msbuild, but this change is only for running MicroBuild commands within SignTool.

@ellahathaway ellahathaway requested a review from mmitche January 13, 2025 21:41
@ellahathaway ellahathaway enabled auto-merge (squash) January 13, 2025 21:41
@ellahathaway ellahathaway merged commit 0cf552b into dotnet:main Jan 14, 2025
11 checks passed
@ellahathaway ellahathaway deleted the windows-netcore branch January 14, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align SignTool MSBuild Usage on Windows with Current Execution Environment

3 participants