Fix .deb signature verification#15238
Merged
ellahathaway merged 1 commit intodotnet:mainfrom Nov 12, 2024
Merged
Conversation
jkoritzinsky
approved these changes
Nov 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #14432
While checking the changes in #15216 via real signing in arcade-validation CI, I discovered that the signed
test.debfile was being reported as "not signed" even after it had been properly signed. The changes in this PR fix this failure.To validate these changes, I locally ran
arcade-validation# ./build.sh --sign /p:OfficialBuildId=20241111.1with the signedtest.debfile that I pulled from https://dev.azure.com/dnceng/internal/_build/results?buildId=2579780&view=artifacts&pathAsName=false&type=publishedArtifacts. The signing passed, with the binlog indicating that the.debfile was already signed: