Merged
Conversation
ellahathaway
requested review from
NikolaMilosavljevic,
ViktorHofer and
jkoritzinsky
jkoritzinsky
reviewed
Nov 4, 2024
Member
Author
|
The classic "it passes locally." I'm not sure why the tests are failing in CI, but I'm investigating. |
jkoritzinsky
previously approved these changes
Nov 5, 2024
Member
jkoritzinsky
left a comment
jkoritzinsky
left a comment
There was a problem hiding this comment.
LGTM once tests are passing
ViktorHofer
reviewed
Nov 5, 2024
ViktorHofer
reviewed
Nov 8, 2024
ViktorHofer
reviewed
Nov 8, 2024
ViktorHofer
reviewed
Nov 8, 2024
ViktorHofer
previously approved these changes
Nov 8, 2024
jkoritzinsky
approved these changes
Nov 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #14432
This code enables the signing of .deb files using SignTool.
The true validation for these changes can only happen internally, but I was able to verify via the SignTool tests and arcade-validation that .deb packages are considered "files to sign" with an expected
LinuxSigncertificate.