Enable Unpacking, repacking, signing, and notarization of .pkg files and .app bundles#15206
Merged
mmitche merged 88 commits intodotnet:mainfrom Jan 16, 2025
Merged
Conversation
This was referenced Oct 29, 2024
ellahathaway
added a commit
to ellahathaway/arcade
that referenced
this pull request
Oct 31, 2024
Co-authored-by: Ella Hathaway <[email protected]>
Co-authored-by: Ella Hathaway <[email protected]>
…ol-unpack-repack-pkg
mmitche
reviewed
Nov 22, 2024
mmitche
reviewed
Nov 22, 2024
mmitche
reviewed
Nov 22, 2024
mmitche
reviewed
Nov 22, 2024
mmitche
reviewed
Nov 22, 2024
Member
|
Readddy for review! |
ViktorHofer
reviewed
Jan 15, 2025
| </PropertyGroup> | ||
|
|
||
| <Import Project="BuildStep.props" /> | ||
| <Import Project="TargetFrameworkDefaults.props" /> |
Member
There was a problem hiding this comment.
I don't see this import being used anywhere below. I don't think that the Arcade TFM properties can be used.
Member
There was a problem hiding this comment.
I think I had this in there to use NetToolCurrent for the command line tools. Updated
ellahathaway
commented
Jan 15, 2025
| <SNBinaryPath Condition="$([MSBuild]::IsOSPlatform('Windows'))">$(NuGetPackageRoot)sn\$(SNVersion)\sn.exe</SNBinaryPath> | ||
|
|
||
| <!-- .pkgs and .app bundle tooling is only available on MacOS --> | ||
| <PkgToolPath Condition="$([MSBuild]::IsOSPlatform('OSX'))">$(NuGetPackageRoot)microsoft.dotnet.macospkg\$(MicrosoftDotNetMacOsPkgVersion)\tools\net10.0\any\Microsoft.Dotnet.MacOsPkg.dll</PkgToolPath> |
Member
Author
There was a problem hiding this comment.
Is there a way to use a prop for net10.0? I think the hardcoded version will cause issues when we eventually update the target framework.
Member
There was a problem hiding this comment.
$(NetToolCurrent). I'll try it.
Co-authored-by: Ella Hathaway <[email protected]>
ellahathaway
commented
Jan 16, 2025
Member
Author
ellahathaway
left a comment
There was a problem hiding this comment.
I cannot approve because I’m technically the author of the PR, but the changes look good to me. Thanks for all the work you did on this, Matt.
Member
ViktorHofer
approved these changes
Jan 16, 2025
NikolaMilosavljevic
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #14438
This is the second part of #14438. This PR integrates the pkg tool, introduced in #15205, into SignTool. More specifically, this PR enables the unpacking and repacking of .pkgs and nested .app bundles within SignTool & adds tests & test data for this functionality into SignTool.Tests.
This is a rather large change, including quite a lot of refactoring as SignTool is becoming a bit bloated. Highlights
There is more follow on work to be done here. Signtool is due for a major refactor to deal with all the various archive types it now supports. There is far too much "If ".