Unpack/Repack Pkg Tooling and Tests by ellahathaway · Pull Request #15205 · dotnet/arcade

ellahathaway · 2024-10-29T16:07:21Z

Related to #14438

This PR introduces a tool that unpacks and repacks .pkg files and nested .app bundles. It also includes test cases and test data for the tool.

The MacOS PKG tool includes the following components:

Program.cs: Driver for unpacking and packing .pkg files and .app bundles.
Package.cs: Class representing a .pkg, responsible for unpacking and repacking .pkg installer packages and component packages.
AppBundle.cs: Class representing an .app bundle, which unpacks and repacks .app directories into .zip files. This is necessary for Enable signing and notarization of .pkg files using SignTool #14435
Utilities.cs: Class that contains helper functions.
ExecuteHelper.cs: Class that runs processes.

ellahathaway · 2024-10-31T18:19:12Z

I'm going to update the tests to include checks against the checksums. When I did this check locally, the checksums were different. I verified that it's the Bom files that are different, so I'm currently working to identify why that is.

In the meantime, I think that the PR is still worth reviewing so I'm going to leave this undrafted.

src/Microsoft.DotNet.Pkg/Processor.cs

ellahathaway · 2024-11-05T16:24:03Z

I'm going to update the tests to include checks against the checksums. When I did this check locally, the checksums were different. I verified that it's the Bom files that are different, so I'm currently working to identify why that is.

In the meantime, I think that the PR is still worth reviewing so I'm going to leave this undrafted.

Filed #15219 to investigate this at a later time.

src/Microsoft.DotNet.Pkg/Processor.cs

src/Microsoft.DotNet.Pkg/PackageBundle.cs

src/Microsoft.DotNet.Pkg.Tests/UnpackRepackTests.cs

src/Microsoft.DotNet.Pkg.Tests/Microsoft.DotNet.Pkg.Tests.csproj

src/Microsoft.DotNet.Pkg/ExecuteHelper.cs

src/Microsoft.DotNet.Pkg.Tests/Microsoft.DotNet.Pkg.Tests.csproj

src/Microsoft.DotNet.Pkg.Tests/UnpackRepackTests.cs

src/Microsoft.DotNet.Pkg/AppBundle.cs

src/Microsoft.DotNet.Pkg/PackageBundle.cs

src/Microsoft.DotNet.Pkg/Processor.cs

src/Microsoft.DotNet.Pkg/Program.cs

src/Microsoft.DotNet.Pkg/Package.cs

src/Microsoft.DotNet.Pkg/ExecuteHelper.cs

src/Microsoft.DotNet.Pkg/Program.cs

src/Microsoft.DotNet.Pkg.Tests/UnpackPackTests.cs

src/Microsoft.DotNet.MacOsPkg.Tests/UnpackPackTests.cs

mmitche · 2024-11-21T15:05:38Z

src/Microsoft.DotNet.MacOsPkg/Microsoft.DotNet.MacOsPkg.csproj

+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <TargetFrameworks>$(NetToolCurrent);$(NetFrameworkToolCurrent)</TargetFrameworks>


Because this can only be run on Mac, this should not need NetFrameworkToolCurrent, correct?

src/Microsoft.DotNet.MacOsPkg.Tests/Microsoft.DotNet.MacOsPkg.Tests.csproj

src/Microsoft.DotNet.MacOsPkg/Microsoft.DotNet.MacOsPkg.csproj

src/Microsoft.DotNet.MacOsPkg/Utilities.cs

src/Microsoft.DotNet.MacOsPkg/Program.cs

Unpack/Repack Pkg Tooling and Tests

fd7b560

ellahathaway requested a review from ViktorHofer October 29, 2024 16:07

This was referenced Oct 29, 2024

Enable unpack/repack of .pkg containers #14438

Closed

Enable Unpacking, repacking, signing, and notarization of .pkg files and .app bundles #15206

Merged

Enable signing and notarization of .pkg files using SignTool #14435

Closed

ellahathaway requested review from NikolaMilosavljevic, ericstj, jkoritzinsky and joeloff October 31, 2024 18:31

Remove tool from SignTool tests - will be added in dotnet#15206

3e81076

joeloff reviewed Oct 31, 2024

View reviewed changes

src/Microsoft.DotNet.Pkg/Processor.cs Outdated Show resolved Hide resolved

joeloff reviewed Oct 31, 2024

View reviewed changes

src/Microsoft.DotNet.Pkg/Processor.cs Outdated Show resolved Hide resolved

ellahathaway mentioned this pull request Nov 5, 2024

Investigate checksum diff between original and repacked .pkg files #15219

Closed

NikolaMilosavljevic reviewed Nov 5, 2024

View reviewed changes

src/Microsoft.DotNet.Pkg/Processor.cs Outdated Show resolved Hide resolved

NikolaMilosavljevic reviewed Nov 5, 2024

View reviewed changes

src/Microsoft.DotNet.Pkg/Processor.cs Outdated Show resolved Hide resolved

NikolaMilosavljevic reviewed Nov 5, 2024

View reviewed changes

src/Microsoft.DotNet.Pkg/Processor.cs Outdated Show resolved Hide resolved

NikolaMilosavljevic reviewed Nov 5, 2024

View reviewed changes

src/Microsoft.DotNet.Pkg/PackageBundle.cs Outdated Show resolved Hide resolved

NikolaMilosavljevic reviewed Nov 5, 2024

View reviewed changes

src/Microsoft.DotNet.Pkg/PackageBundle.cs Outdated Show resolved Hide resolved