Avoid calling string.Trim(ReadOnlySpan<char>)#15134
Merged
bartonjs merged 1 commit intodotnet:mainfrom Oct 6, 2024
Merged
Conversation
The methods are being removed, but the test suite depends on arcade, which is already calling the removed members.
stephentoub
reviewed
Oct 5, 2024
| public class InstallDotNetCore : Microsoft.Build.Utilities.Task | ||
| { | ||
| #endif | ||
| private static readonly char[] s_keyTrimChars = [ '$', '(', ')' ]; |
Member
There was a problem hiding this comment.
From the file below, is the convention in this repo to use _ rather than s_ for statics?
Member
Author
There was a problem hiding this comment.
It looks like most of the private static readonly use s_; but that other file omitted the s.
Member
|
/backport to release/9.0 |
Contributor
|
Started backporting to release/9.0: https://github.com/dotnet/arcade/actions/runs/11241017967 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The methods are being removed, but the test suite depends on arcade, which is already calling the removed members.
Contributes to dotnet/runtime#108537