Skip to content

Set runAsPublic explicitly#15128

Merged
mmitche merged 1 commit intodotnet:mainfrom
mmitche:fixup-runAsPublic
Oct 3, 2024
Merged

Set runAsPublic explicitly#15128
mmitche merged 1 commit intodotnet:mainfrom
mmitche:fixup-runAsPublic

Conversation

@mmitche
Copy link
Member

@mmitche mmitche commented Oct 2, 2024

This is a parameter in jobs.yml as well as core-templates, but is not in the outer templates, despite being used here. Repos that are not using jobs.yml would have arcade generated SBOMs dropped

This is a parameter in jobs.yml as well as core-templates, but is not in the outer templates, despite being used here. Repos that are not using jobs.yml would have arcade generated SBOMs dropped
@mmitche mmitche requested a review from chcosta October 2, 2024 18:42
@mmitche
Copy link
Member Author

mmitche commented Oct 2, 2024

/backport to release/9.0

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

@@ -1,6 +1,7 @@
parameters:
# Sbom related params
enableSbom: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is enableSbom: true not enough for SBOMs to show up?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also curious what else does runAsPublic: false do?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because runAsPublic is empty if you don't use the job.yml template. That means we don't expand the CG steps. These have traditionally been turned off in public projects/PRs as well as when repos want to 'pretend' like they are running as a public run.

@mmitche mmitche merged commit 36084e2 into dotnet:main Oct 3, 2024
@mmitche
Copy link
Member Author

mmitche commented Oct 17, 2024

/backport to release/9.0

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@mmitche an error occurred while backporting to release/9.0, please check the run log for details!

Validation Failed: {"resource":"PullRequest","code":"custom","message":"No commits between release/9.0 and backport/pr-15128-to-release/9.0"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants