SymUploader removal stage 2: Use symbolrequest workflow to promote to internal/external symbol servers #15055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoyosjs
force-pushed
the
dev/juhoyosa/use-symbolrequest-service
branch
from
220fcd8 to
670b117
Compare
mmitche
reviewed
Sep 9, 2024
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs
Outdated
Show resolved
Hide resolved
mmitche
reviewed
Sep 9, 2024
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs
Show resolved
Hide resolved
mmitche
reviewed
Sep 9, 2024
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs
Outdated
Show resolved
Hide resolved
mmitche
reviewed
Sep 9, 2024
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs
Outdated
Show resolved
Hide resolved
mmitche
reviewed
Sep 9, 2024
src/Microsoft.DotNet.Build.Tasks.Feed/src/model/TargetFeedConfig.cs
Outdated
Show resolved
Hide resolved
mmitche
reviewed
Sep 9, 2024
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs
Outdated
Show resolved
Hide resolved
mmitche
reviewed
Sep 9, 2024
Member
|
Does this wait for the symbol promotion to PPE/prod to complete, or does it just exit after submitting the request? Is it okay to just exit after submission? |
hoyosjs
force-pushed
the
dev/juhoyosa/use-symbolrequest-service
branch
from
4af02b6 to
23b2179
Compare
Member
Author
We can add it as an exit criteria or an insertion criteria. But their workflow doesn't have a synchronous option. You call and wait for completion later. |
Member
Author
2 tasks
hoyosjs
force-pushed
the
dev/juhoyosa/use-symbolrequest-service
branch
from
4d06849 to
7d36687
Compare
Member
Author
|
The final test with all changes and proposed yaml change: https://dev.azure.com/dnceng/internal/_build/results?buildId=2535794 |
Member
Author
mikem8361
previously approved these changes
Sep 12, 2024
mmitche
reviewed
Sep 12, 2024
src/Microsoft.DotNet.Build.Tasks.Feed.Tests/PublishToSymbolServerTest.cs
Outdated
Show resolved
Hide resolved
mmitche
reviewed
Sep 12, 2024
src/Microsoft.DotNet.Build.Tasks.Feed.Tests/SetupTargetFeedConfigV3Tests.cs
Outdated
Show resolved
Hide resolved
mmitche
reviewed
Sep 12, 2024
mmitche
reviewed
Sep 12, 2024
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs
Show resolved
Hide resolved
mmitche
reviewed
Sep 12, 2024
src/Microsoft.DotNet.Build.Tasks.Feed/src/model/SetupTargetFeedConfigV3.cs
Outdated
Show resolved
Hide resolved
mmitche
reviewed
Sep 12, 2024
src/Microsoft.DotNet.Internal.SymbolHelper/SymbolPromotionHelper.cs
Outdated
Show resolved
Hide resolved
mmitche
reviewed
Sep 13, 2024
mmitche
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.