SignTool: Use .NET Core MSBuild for Non-Windows#15045
Merged
ellahathaway merged 1 commit intodotnet:mainfrom Sep 5, 2024
Merged
SignTool: Use .NET Core MSBuild for Non-Windows#15045ellahathaway merged 1 commit intodotnet:mainfrom
ellahathaway merged 1 commit intodotnet:mainfrom
Conversation
ellahathaway
force-pushed
the
netcore-msbuild
branch
from
dd97ca4 to
475c3ce
Compare
mmitche
reviewed
Sep 4, 2024
mmitche
approved these changes
Sep 4, 2024
Member
|
My favorite method of end 2 end local testing has always been to do the local feed dance. Key points:
For actual validation for this, we should augment arcade-validation to:
#14431 would cover enabling real signing there. |
Member
Author
Awesome thanks for explaining. I'll work on e2e testing and update this PR if changes are needed. |
Member
Author
|
Finished local testing on linux. Build ran as expected and I verified via the binlogs that the tool was using .NET Core msbuild for building MicroBuild. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14430
I tested these changes locally by running the unit tests via
./test.sh. For e2e testing, I initially considered configuring a local project to pull the SignTool package from a local feed. While this seems viable, the setup can be tedious. If there's a better method for e2e testing, please let me know.