Update Aka.ms link functionality to support client certificates #14810
+159
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable client certificate usage. If the client cert is provided, it is biased over secret support. I left secret support in for now to enable onboarding to certs and offboarding of client secrets.
Member
Author
|
Still a bit of a WIP. Need to verify functionality. But I don't expect things to shift much. |
Member
Author
garath
approved these changes
Jun 6, 2024
Member
Author
|
Process here is that I will merge this, get a good build and then an arcade update, and then the templates will be updated to use the cert rather than the client secret. |
mmitche
added a commit
to mmitche/arcade
that referenced
this pull request
Jun 10, 2024
mmitche
added a commit
that referenced
this pull request
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable client certificate usage. If the client cert is provided, it is biased over secret support. I left secret support in for now to enable onboarding to certs and offboarding of client secrets.
To double check: