Fixup typos in official source-index-stage1.yml #14792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- file was copied from templates/ in @1814df258a66 - reference official templates from other official templates - use 1ES PT syntax in official templates See also https://dev.azure.com/dnceng/internal/_git/dotnet-helix-machines/pullrequest/39779?_a=files&path=/eng/common/templates-official/job/source-index-stage1.yml&discussionId=168924
Contributor
Author
|
While I'm here, I'd appreciate thoughts on the logging in this YAML. @directhex it seems unnecessary and perhaps excessive to me. |
mmitche
approved these changes
May 28, 2024
ViktorHofer
approved these changes
Jun 10, 2024
- no need to echo identifiers - mark identifier variables as secret
Contributor
Author
Talked offline w/ @mmitche. Going w/ the defence in depth approach and minimizing what's visible in console logs. |
mmitche
approved these changes
Jun 10, 2024
mmitche
pushed a commit
to mmitche/arcade
that referenced
this pull request
Jun 21, 2024
…et#14792) - fixup typos in the official template - file was copied from templates/ in 1814df2 - reference official templates from other official templates - use 1ES PT syntax in official templates - see also https://dev.azure.com/dnceng/internal/_git/dotnet-helix-machines/pullrequest/39779?_a=files&path=/eng/common/templates-official/job/source-index-stage1.yml&discussionId=168924 - remove excess logging - no need to echo identifiers - mark identifier variables as secret
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also https://dev.azure.com/dnceng/internal/_git/dotnet-helix-machines/pullrequest/39779?_a=files&path=/eng/common/templates-official/job/source-index-stage1.yml&discussionId=168924
To double check: