Fix syntax error in build-rootfs.sh#14754
Merged
sbomer merged 1 commit intodotnet:mainfrom May 7, 2024
Merged
Conversation
jkoritzinsky
approved these changes
May 7, 2024
Member
|
Ah, it was a last minute PR update, didn't ran shellcheck again. :( Maybe we should run shellcheck in CI for all .sh files under eng/common to avoid accidental changes. |
Member
|
That sounds like a reasonable idea to me. We could do something similar to what we do for MarkdownLint. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is causing errors like
Introduced in #14744 @am11