Use alternate syntax for post-build usage which is not under 1ES PT#14753
Merged
chcosta merged 3 commits intodotnet:mainfrom May 6, 2024
Merged
Use alternate syntax for post-build usage which is not under 1ES PT#14753chcosta merged 3 commits intodotnet:mainfrom
chcosta merged 3 commits intodotnet:mainfrom
Conversation
ghost
reviewed
May 6, 2024
ghost
previously approved these changes
May 6, 2024
akoeplinger
previously approved these changes
May 6, 2024
ghost
previously approved these changes
May 6, 2024
ghost
approved these changes
May 6, 2024
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To double check:
@akoeplinger reported this failure - https://dev.azure.com/dnceng/internal/_build/results?buildId=2445847&view=results
Problem:
The issue is that their repo is running internal builds, and doing "post-build" things, but it's not production so it runs outside of 1ES PT. 1ES PT has different syntax for defining agent pools which ends up ignored if you're not running as 1ES PT and we end up with the wrong agent pool. That leads to running by default on Ubuntu 18.04 which does not have the required pre-reqs for Node and leads to the build failure.
Impact:
This would affect any "official" build which has decided it is non-production and doesn't utilize 1ES PT but does do post-build things.
Validation:
Validated this fix with https://dev.azure.com/dnceng/internal/_build/results?buildId=2445969&view=logs&j=a13e9384-d6d3-5a14-7a96-79282fc11262&t=5254e7fd-b1f1-4d04-8b9d-e51752bafa8b
*Note: the validation build job is running very long. I'm not super familiar with the SourceLink step, but I think that it's running long because i am using my dev branch.