Skip to content

Fix a typo in expressions usage of properties instead of parameters#14749

Merged
akoeplinger merged 2 commits intodotnet:mainfrom
ChristopherHX:patch-1
May 3, 2024
Merged

Fix a typo in expressions usage of properties instead of parameters#14749
akoeplinger merged 2 commits intodotnet:mainfrom
ChristopherHX:patch-1

Conversation

@ChristopherHX
Copy link
Copy Markdown
Contributor

@ChristopherHX ChristopherHX commented Apr 30, 2024

My Custom Azure Pipelines VSCode Extension found this problem under the copy inside dotnet/runtime

As long properties is not defined, azure pipelines will happily ignore this typo, my extension throws an validation error

To double check:

@ChristopherHX ChristopherHX changed the title Fix a typo in runtime expressions usage of properties instead of para… Fix a typo in expressions usage of properties instead of parameters Apr 30, 2024
@akoeplinger akoeplinger requested a review from chcosta May 2, 2024 17:26
chcosta
chcosta previously approved these changes May 2, 2024
@chcosta chcosta dismissed their stale review May 2, 2024 18:40

double checking something

@chcosta
Copy link
Copy Markdown
Member

chcosta commented May 2, 2024

Sorry, would you mind also fixing this in eng/common/templates-official/steps/publish-pipeline-artifacts.yml?

@ChristopherHX
Copy link
Copy Markdown
Contributor Author

@dotnet-policy-service agree

@ChristopherHX
Copy link
Copy Markdown
Contributor Author

Sorry, would you mind also fixing this in eng/common/templates-official/steps/publish-pipeline-artifacts.yml?

No problem, done.

@akoeplinger akoeplinger merged commit 020255b into dotnet:main May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants