Add curl support in build-rootfs.sh#14744
Merged
akoeplinger merged 3 commits intodotnet:mainfrom May 7, 2024
Merged
Conversation
Member
Author
|
@akoeplinger, PTAL. |
Member
|
I don't have a strong opinion but I wonder if it'd be easier to read and more maintainable to just do a |
Member
Author
|
Switched to inline view. I agree it's more readable (easy to copy-paste and test in isolation). |
am11
force-pushed
the
patch-11
branch
2 times, most recently
from
7aea4d9 to
8d1b8d6
Compare
akoeplinger
reviewed
May 6, 2024
Member
akoeplinger
left a comment
akoeplinger
left a comment
There was a problem hiding this comment.
One comment, LGTM otherwise
eng/common/cross/build-rootfs.sh
Outdated
| elif command -v curl &> /dev/null; then | ||
| __hasWget=0 | ||
| else | ||
| >&2 echo "ERROR: either wget or curl is required by this script." |
Member
There was a problem hiding this comment.
the ubuntu/debian/tizen cases don't need wget/curl today so I'd prefer not erroring to keep the same behavior
Member
Author
There was a problem hiding this comment.
Extracted into ensureDownloadTool() function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are systems which come preinstalled with wget, curl, both or none. To make things smoother, this PR adds curl support side-by-side wget. We have this flexibility in other scripts as well.