Skip to content

Add opt-out switch for including default publish items and add Manife…#14602

Merged
ViktorHofer merged 4 commits intomainfrom
ViktorHofer-patch-4
Mar 18, 2024
Merged

Add opt-out switch for including default publish items and add Manife…#14602
ViktorHofer merged 4 commits intomainfrom
ViktorHofer-patch-4

Conversation

@ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Mar 18, 2024

…stArtifactData consistently

  1. Add opt-out switch EnableDefaultPublishItems!=true to not glob for all nuget packages under artifacts/packages
  2. Set ManifestArtifactData metadata in the target that reads from it so that it also applies to items that are manually added.

Tested locally. Unblocks dotnet/windowsdesktop#4251

…stArtifactData consistently

1. Add opt-out switch `EnableDefaultPublishItems!=true` to not glob for all nuget packages under artifacts/packages
2. Set ManifestArtifactData metadata in an ItemDefinitionGroup so that it also applies to items that are manually added.
@ViktorHofer ViktorHofer requested a review from mmitche March 18, 2024 12:39
@ViktorHofer ViktorHofer enabled auto-merge (squash) March 18, 2024 13:56
@ViktorHofer ViktorHofer merged commit bb0a3bb into main Mar 18, 2024
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-4 branch March 18, 2024 15:12
Copy link
Member

@mmitche mmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants