Skip to content

Use the 1ES publishing tasks in some missed places in templates-official job.yml #14568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
riarenas merged 2 commits into from
Mar 11, 2024
Merged

Use the 1ES publishing tasks in some missed places in templates-official job.yml #14568

riarenas merged 2 commits into from
Mar 11, 2024

Conversation

@riarenas
Copy link
Contributor

@riarenas riarenas commented Mar 8, 2024 •
edited
Loading

dotnet/dnceng#2133

The - publish: steps that are shortcuts to the publish pipeline artifact task were not converted.

I'm working on getting a test build of these changes (I need a better process for this... at this rate maybe it makes sense to convert arcade just to speed up testing) and I will share one as soon as I have it.

To double check:

@riarenas riarenas requested review from chcosta and mmitche March 8, 2024 22:53
@riarenas
Copy link
Contributor Author

riarenas commented Mar 11, 2024

https://dnceng.visualstudio.com/internal/_build/results?buildId=2400063&view=results for a test build in symreader... I see already that the log and build retry configuration publish were successfully injected into the run, and if it succeeds I'll merge / backport this to release/8.0.

@riarenas
Copy link
Contributor Author

riarenas commented Mar 11, 2024 •
edited
Loading

My test build published the retry configuration, but not the logs through the template. Since the log publishing uses artifacts/log instead of a complete path to publish, I don't want to risk merging without exercising that, so I think I enabled this in my newest test build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2400122&view=results

@riarenas
Copy link
Contributor Author

riarenas commented Mar 11, 2024

Log artifact was uploaded just fine in new test build:
image

I think this is good to go.

@riarenas riarenas merged commit 39839f3 into dotnet:main Mar 11, 2024
@riarenas
Copy link
Contributor Author

riarenas commented Mar 11, 2024

/backport to release/8.0

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2024

Started backporting to release/8.0: https://github.com/dotnet/arcade/actions/runs/8238599200

@github-actions github-actions bot mentioned this pull request Mar 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chcosta chcosta chcosta approved these changes

@mmitche mmitche Awaiting requested review from mmitche

+1 more reviewer

@AlitzelMendez AlitzelMendez AlitzelMendez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@riarenas @AlitzelMendez @chcosta