Increment NetCurrent and NetPrevious#14108
Conversation
|
I'm unsure of the rollout of this. It would force repos to take a dependency on a newer SDK in order to get the arcade dependency. |
I think we should wait on this a bit until the net9 SDK is stable. Then I would do the following:
Separating the new SDK usage from the tfm update should reduce some noise. |
|
Agreed. I think it's weeks too early to increment these TFM properties across the stack. Probably a month or so to let the stack first stabilize (i.e. dotnet/sdk and installer). |
ViktorHofer
left a comment
ViktorHofer
left a comment
There was a problem hiding this comment.
Please change L40 to:
<NetToolMinimum>net8.0</NetToolMinimum>
<NetToolMinimum Condition="'$(NetToolMinimum)' == '$(NetToolCurrent)'" />
| } | ||
| $dotnetPath = Join-Path $dotnetRoot (GetExecutableFileName 'dotnet') | ||
| $buildTool = @{ Path = $dotnetPath; Command = 'msbuild'; Tool = 'dotnet'; Framework = 'net8.0' } | ||
| $buildTool = @{ Path = $dotnetPath; Command = 'msbuild'; Tool = 'dotnet'; Framework = 'net9.0' } |
There was a problem hiding this comment.
I think this change needs to wait until the updated Arcade.Sdk is consumed in Arcade.
|
I pushed to your branch to reset NetPrevious. Hope that's OK. |
|
This is replaced by #14279. |
3 participants
No description provided.