[main] Update dependencies from dotnet/arcade dotnet/arcade-services#13938
Merged
[main] Update dependencies from dotnet/arcade dotnet/arcade-services#13938
Conversation
…ild 20230802.2 Microsoft.DotNet.Maestro.Client From Version 1.1.0-beta.21553.1 -> To Version 1.1.0-beta.23402.2
Member
|
OMG this hasn't been updated in almost 2 years. |
Member
|
Okay well it works. Surprising AND good! |
Contributor
|
Curious that the maestro tasks didn't get updated along with this? did we stop producing that in arcade-services? |
Member
|
Maybe that's why it worked :D |
Contributor
Are the tasks what we need to take the update for? |
Member
|
Yep, I want this change: dotnet/arcade-services#2763 |
Contributor
|
classic. SO it seems like the package is not produced anymore. It's also no longer present in the manifest. I wonder if it lost its |
Member
|
It looks like it never did! I wonder whether PackageType != '' used to imply IsPackable == true? mmitche/arcade-services@7668666#diff-c35f69b5811b502d024e504e329096a1fff92fff66a7b62364955353a499cefdR8 |
Member
|
Nope, I bet this did it: dotnet/arcade-services#2291 |
Member
|
My hunch is that the change there mistakenly disabled the Maestro tasks build, That should still be produced out of arcade-services, unless we want to move it back into arcade. |
Member
…802.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild From Version 8.0.0-beta.23401.3 -> To Version 8.0.0-beta.23402.2
dotnet-maestro
bot
changed the title
…ild 20230802.5 Microsoft.DotNet.Maestro.Client , Microsoft.DotNet.Maestro.Tasks From Version 1.1.0-beta.21553.1 -> To Version 1.1.0-beta.23402.5
dotnet-maestro
bot
changed the title
…803.7 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild From Version 8.0.0-beta.23401.3 -> To Version 8.0.0-beta.23403.7
dotnet-maestro
bot
changed the title
dotnet-maestro
bot
changed the title
riarenas
approved these changes
Aug 4, 2023
dotnet-maestro
bot
deleted the
darc-main-0ec85133-bf0a-43b6-8811-3691067aaeda
branch
Member
|
Is this what broke runtime official build (or more likely the xliff bump)? see dotnet/sdk#34522 (comment) OneLoc started failing in the range this landed in runtime |
Member
|
this is the error, upstream of what @radical pasted this does not appear in the earlier successful builds. Note these files don't exist -- only the localized ones in sub folders. Perhaps the build creates them ? I didn't see any relevant changes to Someone will have to inspect a build machine or run a loc build locally. Note -- I also diffed the good and bad locbuild logs -- they are essentially identical up to the point of the error, so there's no evidence it's caused by a new version of any of the various packages/tools listed in that log. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
From https://github.com/dotnet/arcade-services
From https://github.com/dotnet/arcade