Skip to content

Conversation

@ViktorHofer
Copy link
Member

Reverts #13825

Now that Arcade requires the .NET 8 Preview 6 SDK, we can remove the sourcelink Arcade support.

@ViktorHofer ViktorHofer requested review from mmitche and tmat July 12, 2023 15:31
@ViktorHofer
Copy link
Member Author

ViktorHofer commented Jul 12, 2023

@mmitche I wonder if we should we also remove the sourcelink version from Versions.props as part of this change?

@mmitche
Copy link
Member

mmitche commented Jul 12, 2023

Yes. Keep the Version.Details.xml entries for now.

mmitche
mmitche previously approved these changes Jul 12, 2023
tmat
tmat previously approved these changes Jul 12, 2023
wtgodbe
wtgodbe previously approved these changes Jul 12, 2023
@ViktorHofer ViktorHofer dismissed stale reviews from wtgodbe, tmat, and mmitche via 889b098 July 12, 2023 18:09
@ViktorHofer ViktorHofer enabled auto-merge (squash) July 12, 2023 18:35
@ViktorHofer ViktorHofer merged commit 7f922d5 into main Jul 12, 2023
@ViktorHofer ViktorHofer deleted the revert-13825-revert-13260-RemoveSourceLinkRefs branch July 12, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants