Skip to content

Revert "Remove Source Link package references" #13825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ViktorHofer merged 1 commit into from
Jun 16, 2023
Merged

Revert "Remove Source Link package references" #13825

ViktorHofer merged 1 commit into from
Jun 16, 2023

Conversation

@ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Jun 16, 2023 •
edited
Loading

Reverts #13260

See dotnet/arcade-validation#3844 (comment)

We need to revert this change until Arcade upgrades to an SDK that includes dotnet/sdk#33292.

@ViktorHofer ViktorHofer requested review from mmitche and tmat June 16, 2023 07:15
@ViktorHofer ViktorHofer merged commit 4bbdd77 into main Jun 16, 2023
@ViktorHofer ViktorHofer deleted the revert-13260-RemoveSourceLinkRefs branch June 16, 2023 14:17
@ViktorHofer ViktorHofer mentioned this pull request Jul 11, 2023
Merged
ViktorHofer added a commit that referenced this pull request Jul 12, 2023
@ViktorHofer
Revert "Revert "Remove Source Link package references (#13260)" (#13825…
ae150fc 
…)"

This reverts commit 4bbdd77.
@ViktorHofer ViktorHofer mentioned this pull request Jul 12, 2023
Merged
ViktorHofer added a commit that referenced this pull request Jul 12, 2023
@ViktorHofer
Revert "Revert "Remove Source Link package references"" (#13892)
7f922d5 
* Revert "Revert "Remove Source Link package references (#13260)" (#13825)"

This reverts commit 4bbdd77.

* Update Versions.props

* Update Versions.props
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmat tmat Awaiting requested review from tmat

@mmitche mmitche Awaiting requested review from mmitche

1 more reviewer

@riarenas riarenas riarenas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ViktorHofer @riarenas