Remove Source Link package references #13260
Conversation
ViktorHofer
left a comment
ViktorHofer
left a comment
There was a problem hiding this comment.
I'm excited to see sourcelink support added directly into the SDK.
We must wait until Arcade updates to an SDK that has the implicit sourcelink support though. Based on dotnet/sdk@dd2e7b5, that would be 8.0 Preview 4.
We should also communicate this change with the Arcade Engineering Partners alias as this is a breaking change. Before, you could set an explicit source link package version and Arcade would have respected that while now such an explicit version would just be ignored.
|
Yep, this should not be merged until p4 is released and arcade updates to P4. |
eng/Version.Details.xml
Outdated
| <Uri>https://github.com/dotnet/linker</Uri> | ||
| <Sha>3efd231da430baa0fd670e278f6b5c3e62834bde</Sha> | ||
| </Dependency> | ||
| <Dependency Name="Microsoft.SourceLink.GitHub" Version="8.0.0-beta.23218.3"> |
There was a problem hiding this comment.
We should exclude these changes initially. Most repos have coherent parent dependency attributes on their sourcelink dependencies. This means that the arcade updates will fail. Instead, you should:
- Do the changes in
eng/Versions.propsandRepositoryInfo.targets - Flow this to all repos
- Remove the sourcelink dependencies in all repos'
Version.Details.xml - Remove the sourcelink dependencies here.
|
@tmat the PR is now unblocked and it looks like a few repositories are currently broken because of the feed changes (dotnet-tools to dotnet8). Do you have time to react to the feedback or do you want me to help you? |
|
@ViktorHofer Help would be appreciated. Thanks! |
This reverts commit 728a7d3.
3 participants
Source Link is now included in .NET SDK.