Skip to content

Allow override test logs default location #12677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MattGal merged 2 commits into from
Feb 23, 2023
Merged

Allow override test logs default location #12677

MattGal merged 2 commits into from
Feb 23, 2023

Conversation

@RussKie
Copy link
Contributor

@RussKie RussKie commented Feb 22, 2023

By default test logs are written under $(ArtifactsLogDir). However, in situations where there are too many test projects, the logs folder gets innundated with files, making it difficult to explore (especially in CI).

Resolves #12485

Here are the test results with 8.0.0-beta.23120.2:

diff --git a/eng/ArcadeSdkImports.props b/eng/ArcadeSdkImports.props
index 31789da..a3df407 100644
--- a/eng/ArcadeSdkImports.props
+++ b/eng/ArcadeSdkImports.props
@@ -40,6 +40,12 @@
 
+    <!-- Redirect test logs into a subfolder -->
+    <TestResultsLogDir>$([MSBuild]::NormalizeDirectory('$(ArtifactsLogDir)', 'TestLogs'))</TestResultsLogDir>
   </PropertyGroup>

image

@RussKie
Allow override test logs default location
52bb620 
By default test logs are written under `$(ArtifactsLogDir)`. However, in
situations where there are too many test projects, the logs folder gets
innundated with files, making it difficult to explore (especially in CI).

Resolves #12485
riarenas
riarenas previously approved these changes Feb 22, 2023
View reviewed changes
MattGal
MattGal previously approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@MattGal MattGal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. Would you mind adding a blurb around https://github.com/dotnet/arcade/blob/main/Documentation/ArcadeSdk.md#testrunneradditionalarguments-string to let future people find this more easily?

@RussKie RussKie dismissed stale reviews from MattGal and riarenas via 38cbb15 February 23, 2023 03:05
@RussKie
Copy link
Contributor Author

RussKie commented Feb 23, 2023

Updated. If you're happy, merge at will. Thank you.

@MattGal MattGal merged commit e438fce into main Feb 23, 2023
@RussKie RussKie deleted the fix_12485 branch March 20, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MattGal MattGal MattGal approved these changes

@michellemcdaniel michellemcdaniel Awaiting requested review from michellemcdaniel

+1 more reviewer

@riarenas riarenas riarenas left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow customise test log output location

4 participants

@RussKie @MattGal @riarenas