Skip to content

Set repo URL conditionally #12660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
janvorli merged 2 commits into from
Feb 22, 2023
Merged

Set repo URL conditionally #12660

janvorli merged 2 commits into from
Feb 22, 2023

Conversation

@am11
Copy link
Member

@am11 am11 commented Feb 21, 2023 •
edited
Loading

If repo URL is set by architecture branch, we don't need to override it.

This was breaking riscv64 on Debian sid (sets URL to debian-ports in its branch).

cc @janvorli

janvorli
janvorli approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@janvorli janvorli merged commit 2d159c1 into dotnet:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janvorli janvorli janvorli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@am11 @janvorli