Skip to content

Upgrade Arcade to .NET 8 SDK and TFM#12096

Merged
ViktorHofer merged 7 commits intodotnet:mainfrom
ViktorHofer:Net8Tfm
Jan 5, 2023
Merged

Upgrade Arcade to .NET 8 SDK and TFM#12096
ViktorHofer merged 7 commits intodotnet:mainfrom
ViktorHofer:Net8Tfm

Conversation

@ViktorHofer
Copy link
Member

Builds on-top of the work from last year: #9127

The chosen SDK just released today and finally contains the .NET 8 targeting pack and runtime.

To double check:

@ViktorHofer
Copy link
Member Author

ViktorHofer commented Jan 5, 2023

from arcade-ci (Build SourceIndexStage1)

Unsupported log file format. Latest supported version is 14, the log file has version 15.

@alexperovich @mmitche do you remember what needs to be done to update the BinLogToSln tooling?

@riarenas
Copy link
Contributor

riarenas commented Jan 5, 2023

@ViktorHofer I'm not really up to speed with the source indexing, but looking at #11995, it seems like @MattGal published a version which might work with v15?

Could try changing

sourceIndexPackageVersion: 1.0.1-20220804.1
to 1.0.1-20221220.2

@mmitche
Copy link
Member

mmitche commented Jan 5, 2023

@ViktorHofer I think it may make sense to factor out the TFM property into a top-level property to make upgrades touch fewer files the next time around.

@ViktorHofer
Copy link
Member Author

ViktorHofer commented Jan 5, 2023

I think it may make sense to factor out the TFM property into a top-level property to make upgrades touch fewer files the next time around.

Arcade already does that (we changed that last year as part of #9127):

<TargetFrameworkForNETSDK>net7.0</TargetFrameworkForNETSDK>

The file changes in this PR are for props and targets files inside nuget packages which hardcode the TFM. In the past we discussed if we would like to automate that, but the cost vs benefit wasn't great at that time.

@mmitche
Copy link
Member

mmitche commented Jan 5, 2023

I think it may make sense to factor out the TFM property into a top-level property to make upgrades touch fewer files the next time around.

Arcade already does that (we changed that last year as part of #9127):

<TargetFrameworkForNETSDK>net7.0</TargetFrameworkForNETSDK>

The file changes in this PR are for props and targets files inside nuget packages which hardcode the TFM. In the past we discussed if we would like to automate that, but the cost vs benefit wasn't great at that time.

Oh. good call. Thanks.

mmitche
mmitche previously approved these changes Jan 5, 2023
@MichaelSimons
Copy link
Member

I'm going to defer my signoff to @lbussell since he did this for the 7.0 release.

@MichaelSimons MichaelSimons removed their request for review January 5, 2023 18:20
@ViktorHofer ViktorHofer merged commit 7502a87 into dotnet:main Jan 5, 2023
@ViktorHofer ViktorHofer deleted the Net8Tfm branch January 5, 2023 21:36
ViktorHofer added a commit to ViktorHofer/arcade that referenced this pull request Dec 12, 2023
Builds on top of the work from last year: dotnet#12096

Installer version: 9.0.100-alpha.1.23612.1
AspNetCore runtime version: 9.0.0-alpha.1.23577.26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants