Unified Build: Trimming and Targeting Design #11903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is a design to help repos enable targeting of desired TFMs, and to enable trimming away of unwanted TFMs based on the consumer of a build.
mmitche
force-pushed
the
trimming-and-targeting
branch
from
eb23ae9 to
72005a4
Compare
mmitche
requested review from
a team,
jaredpar,
marcpopMSFT and
rainersigwald
mmitche
changed the title
tkapin
reviewed
Dec 12, 2022
Co-authored-by: Michael Simons <[email protected]>
Co-authored-by: Michael Simons <[email protected]>
Co-authored-by: Michael Simons <[email protected]>
…mming-and-targeting
Co-authored-by: Michael Simons <[email protected]>
…mming-and-targeting
jkotas
reviewed
Dec 13, 2022
jkotas
reviewed
Dec 14, 2022
premun
reviewed
Dec 14, 2022
Co-authored-by: Přemek Vysoký <[email protected]>
Co-authored-by: Přemek Vysoký <[email protected]>
Co-authored-by: Přemek Vysoký <[email protected]>
Co-authored-by: Přemek Vysoký <[email protected]>
Co-authored-by: Přemek Vysoký <[email protected]>
Co-authored-by: Přemek Vysoký <[email protected]>
Co-authored-by: Přemek Vysoký <[email protected]>
Co-authored-by: Přemek Vysoký <[email protected]>
Co-authored-by: Přemek Vysoký <[email protected]>
Co-authored-by: Přemek Vysoký <[email protected]>
Co-authored-by: Přemek Vysoký <[email protected]>
Co-authored-by: Přemek Vysoký <[email protected]>
…mming-and-targeting
Member
Author
|
@rainersigwald Gentle ping now that we're back in the new year. |
rainersigwald
approved these changes
Jan 12, 2023
Member
rainersigwald
left a comment
rainersigwald
left a comment
There was a problem hiding this comment.
Adding this functionality to MSBuild is ok with me, I think. If it's a screaming success in Arcade we might consider promoting the filtering to the SDK.
@baronfel holler if you really don't like the new property function :)
| <_OriginalTargetFrameworks Condition="'$(TargetFramework)' != ''">$(TargetFramework)</_OriginalTargetFrameworks> | ||
| <_FilteredTargetFrameworks Condition="'$(NoTargetFrameworkFiltering)' != 'true' and '$(DotNetTargetFrameworkFilter)' != ''">$([MSBuild]::Unescape($([MSBuild]::IntersectTargetFrameworks('$(_OriginalTargetFrameworks)', '$(DotNetTargetFrameworkFilter)'))))</_FilteredTargetFrameworks> | ||
| <TargetFrameworks Condition="'$(NoTargetFrameworkFiltering)' != 'true' and '$(_FilteredTargetFrameworks.Contains(';'))'">$(_FilteredTargetFrameworks)</TargetFrameworks> | ||
| <TargetFramework Condition="'$(NoTargetFrameworkFiltering)' != 'true' and '!$(_FilteredTargetFrameworks.Contains(';'))'">$(_FilteredTargetFrameworks)</TargetFramework> |
Member
There was a problem hiding this comment.
Talked to @mmitche offline--I don't think this part will work but making the project always multitargeted (sometimes with a list of one) shouldn't have an serious cost even if it's not theoretically optimal.
Member
|
@rainersigwald and I chatted briefly about it - the mechanism of set-intersection seems useful enough, I just wished that we had a better syntax for it. no objections from my end to the new primitive function, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a design to help repos enable targeting of desired TFMs, and to enable trimming away of unwanted TFMs based on the consumer of a build.
To double check: