update secret-manager tooling #11855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattGal
approved these changes
Jan 9, 2023
Contributor
Author
|
I went through the existing PATs in dn-bot's account and the scopes in the manifests seem to match what we have right now. I can't find a good way to query the organizations for which a PAT is enabled that isn't manual. Any failures that result from automatic cycling should be dealt with by updating the manifests with any missing scopes or organizations that weren't accounted for. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #11745
To double check:
This updates secret-manager to a version that is able to automatically cycle azure devops tokens. The secret manifests in this repo already contain the scope and organizations information necessary for the tool to work.