Skip to content

Update default msbuild for sdk tasks #11266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mmitche merged 1 commit into from
Oct 13, 2022
Merged

Update default msbuild for sdk tasks #11266

mmitche merged 1 commit into from
Oct 13, 2022

Conversation

@mmitche
Copy link
Member

@mmitche mmitche commented Oct 13, 2022

rc2 requires 17.3.0+. Should fix sign-check error in arcade-validation

To double check:

@mmitche mmitche requested a review from riarenas October 13, 2022 16:01
@riarenas
Copy link
Contributor

riarenas commented Oct 13, 2022

I think there's a process to generate these packages, I still see 17.2.1 as the latest version in the feed: https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet-eng/NuGet/RoslynTools.MSBuild/versions

@riarenas
Copy link
Contributor

riarenas commented Oct 13, 2022

We should also update here:

arcade/eng/common/tools.ps1

Line 369 in afc901d

$defaultXCopyMSBuildVersion = '17.2.1'

@riarenas
Copy link
Contributor

riarenas commented Oct 13, 2022

I'm failing to find the docs on how to generate a new xcopy msbuild. I think @MattGal dealt with this last. Do you happen to remember where the docs for this are?

@mmitche
Copy link
Member Author

mmitche commented Oct 13, 2022

https://teams.microsoft.com/l/message/19:[email protected]/1623351242618?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=147df318-61de-4f04-8f7b-ecd328c256bb&parentMessageId=1623350658056&teamName=.NET%20Eng%20Services&channelName=Arcade%20Guardians&createdTime=1623351242618&allowXTenantAccess=false

@MattGal
Copy link
Member

MattGal commented Oct 13, 2022

I'm failing to find the docs on how to generate a new xcopy msbuild. I think @MattGal dealt with this last. Do you happen to remember where the docs for this are?

It's in the readme in https://github.com/jaredpar/xcopy-msbuild

@mmitche
Update default msbuild for sdk tasks
a5161b0 
rc2 requires 17.3.0+. Should fix sign-check error in arcade-validation
@mmitche mmitche enabled auto-merge (squash) October 13, 2022 20:10
@mmitche mmitche merged commit 02e2831 into release/7.0 Oct 13, 2022
@akoeplinger
Copy link
Member

akoeplinger commented Oct 19, 2022

Should we port this to main?

@akoeplinger
Copy link
Member

akoeplinger commented Nov 4, 2022

/backport to main

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

Started backporting to main: https://github.com/dotnet/arcade/actions/runs/3393360814

@github-actions github-actions bot mentioned this pull request Nov 4, 2022
Merged
@akoeplinger akoeplinger deleted the mmitche-patch-8 branch November 22, 2022 10:16
@MilenaHristova MilenaHristova mentioned this pull request May 19, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@riarenas riarenas riarenas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mmitche @riarenas @MattGal @akoeplinger