Add vestigial objects one-pager #11037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattGal
reviewed
Sep 28, 2022
Member
MattGal
left a comment
MattGal
left a comment
There was a problem hiding this comment.
This looks great. Could it get a bit more crisp on the tasks and maybe SWAG out their costs too?
| @@ -0,0 +1,118 @@ | |||
| # "Vestigal objects" one-pager | |||
Member
There was a problem hiding this comment.
Nit: Spelling (Vestigial). Feel free to use some other term for this too, of course.
|
|
||
| Azure allows "Tags", which are simply key-value pairs, to be arbitrarily associated with almost any resource. Internally, Microsoft already uses this feature to track assets and configuration across subscriptions (e.g., AzSecPack, NRMSException). "Inventory" is an explicit use case supported in Azure. | ||
|
|
||
| This effort will develop a set of standard Tags that will be applied to resources. These Tags will identify, at minimum, resources that are necessary for operation of our services. |
Member
There was a problem hiding this comment.
How do the tags get applied to the resources?
| - [ ] Evaluate including Key Vault auditing information | ||
| - [ ] Develop Dashboards presenting data to expected audience. Consider Grafana and Power BI (or a mix of both). | ||
| - [ ] FR can quickly view changes to an arbitrary resource | ||
| - [ ] New resources or resources with an unknown purpose are easily identifiable |
Member
There was a problem hiding this comment.
Maybe a nitpick but many of these tasks like "resources are easily identifiable" sound like goals.... consider separating them so we can think more easily about costing.
MattGal
approved these changes
Oct 12, 2022
jonfortescue
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a one-pager for the "Vestigial Objects" effort planned as part of dotnet/dnceng#1274.
Closes #10374.