[release/7.0] Work around path length issue when repacking some wixpacks#10813
Merged
mmitche merged 1 commit intodotnet:release/7.0from Sep 12, 2022
Merged
[release/7.0] Work around path length issue when repacking some wixpacks#10813mmitche merged 1 commit intodotnet:release/7.0from
mmitche merged 1 commit intodotnet:release/7.0from
Conversation
The wixpacks were extracted to a unique folder. Becuase the base temp path was already a little long, this sent the arm64 bundle over the edge into path too long territory. Shorten.
ghost
approved these changes
Sep 12, 2022
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Unfortunate but makes sense. The chance of collision is only for the same run of the signtool? or does something get uploaded with the entire path?
Member
Author
Nothing gets upload with the path. It's just a temp path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wixpacks were extracted to a unique folder. Becuase the base temp path was already a little long, this sent the arm64 bundle over the edge into path too long territory. Shorten.