Skip to content

Add compact console formatter #10787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
premun merged 2 commits into from
Sep 26, 2022
Merged

Add compact console formatter #10787

premun merged 2 commits into from
Sep 26, 2022

Conversation

@premun
Copy link
Member

@premun premun commented Sep 9, 2022 •
edited
Loading

Adds a custom console formatter that turns this:

info: Microsoft.DotNet.DarcLib.VirtualMonoRepo.VmrUpdater[0]
      Synchronizing installer from fdc96a7d0f3780df1aaee687692ba4145bb61d85 to https://github.com/dotnet/installer@HEAD
info: Microsoft.DotNet.DarcLib.VirtualMonoRepo.VmrUpdater[0]
      Clone of https://github.com/dotnet/installer found, pulling new changes...
info: Microsoft.DotNet.DarcLib.VirtualMonoRepo.VmrUpdater[0]
      Creating diff in /data/tmp/installer.patch..
info: Microsoft.DotNet.DarcLib.VirtualMonoRepo.VmrUpdater[0]
      Diff created at /data/tmp/installer.patch - 0 commits, 355.058 KB
info: Microsoft.DotNet.DarcLib.VirtualMonoRepo.VmrUpdater[0]
      Applying patch /data/tmp/installer.patch to src/installer...
info: Microsoft.DotNet.DarcLib.VirtualMonoRepo.VmrUpdater[0]
      Committing..
info: Microsoft.DotNet.DarcLib.VirtualMonoRepo.VmrUpdater[0]
      Created 764adb0 in 4 seconds

into this

info: Synchronizing installer from fdc96a7d0f3780df1aaee687692ba4145bb61d85 to https://github.com/dotnet/installer@HEAD
info: Clone of https://github.com/dotnet/installer found, pulling new changes...
info: Creating diff in /data/tmp/installer.patch..
info: Diff created at /data/tmp/installer.patch - 0 commits, 355.058 KB
info: Applying patch /data/tmp/installer.patch to src/installer...
info: Committing..
info: Created 764adb0 in 4 seconds

The update of the Logging library triggered a small avalanche so I had to update few more things. Hopefully this won't break anyone down the line?

@premun premun requested a review from epananth September 12, 2022 09:44
@premun
Copy link
Member Author

premun commented Sep 16, 2022

@adiaaida @missymessa can you help me review this / get this merged? I'd then consume this in arcade-services.
(picking on you two as you interacted on the Teams thread the most)

@premun premun merged commit 21ac4f0 into dotnet:main Sep 26, 2022
@premun premun deleted the prvysoky/formatter branch September 26, 2022 09:17
@premun premun mentioned this pull request Sep 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oleksandr-didyk oleksandr-didyk oleksandr-didyk approved these changes

@riarenas riarenas Awaiting requested review from riarenas

@missymessa missymessa Awaiting requested review from missymessa

@michellemcdaniel michellemcdaniel Awaiting requested review from michellemcdaniel

@epananth epananth Awaiting requested review from epananth

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@premun @oleksandr-didyk