Non-determinism in publishing in presence of errors#10484
Merged
epananth merged 5 commits intodotnet:mainfrom Aug 26, 2022
Merged
Non-determinism in publishing in presence of errors#10484epananth merged 5 commits intodotnet:mainfrom
epananth merged 5 commits intodotnet:mainfrom
Conversation
alexperovich
approved these changes
Aug 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To double check:
Issue -> #10360
We should not read Log.HasLoggedErrors to determine what to do here. That way it will not PublishAssetsWithoutStreamingPublishingAsync will not stop when an error is logged here
arcade/src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs
Line 1141 in 71994b4