Skip to content

Conversation

@GrabYourPitchforks
Copy link
Member

@GrabYourPitchforks GrabYourPitchforks commented Jul 29, 2022

Updates the zlib package we're ingesting on illumos. Contributes to dotnet/runtime#69652.

I'm also about to send a separate PR to the runtime repo which updates the source files we have checked in. Between the two PRs, I believe the work item will be complete.

@am11
Copy link
Member

am11 commented Jul 29, 2022

This version is unfortunately not available on pkgsrc.joyent.com or the skylime mirror: https://pkgsrc.smartos.skylime.net/packages/SmartOS/2020Q1/x86_64/All/zlib-1.2.12.tgz (v1.2.11 exist)

@jperkin, I noticed that zlib 1.2.12 was updated in the manifest https://github.com/TritonDataCenter/pkgsrc/blob/trunk/devel/zlib/Makefile, do you know when the package will be available for consumption?

@jperkin
Copy link

jperkin commented Jul 29, 2022

2020Q1 is not an LTS release and was EOL over 2 years ago. 1.2.12 is available in the trunk repository.

@am11
Copy link
Member

am11 commented Jul 29, 2022

Thank you! I missed the quarter reference.

@GrabYourPitchforks, updating the pinned 2020Q1 reference to floating trunk will break other packages. I will modify the script separately such that it pulls the manifest, and find the latest version of each package that we need.

@GrabYourPitchforks
Copy link
Member Author

@am11 No worries. Thank you for looking at this. :)

I'll just hold tight and wait for your changes to come through first. If it would instead be easier for you to handle everything (including this) as a single separate PR, let me know and I can close this one.

@am11
Copy link
Member

am11 commented Jul 29, 2022

I have opened #10215 so we use trunk repository.

@GrabYourPitchforks
Copy link
Member Author

Closing in favor of #10215.

@GrabYourPitchforks GrabYourPitchforks deleted the levib/zlib branch August 3, 2022 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants