Update Guardian to Latest! Part Deux #10141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Do you have a log of running this internally showing it works? |
Member
Author
Yep, build 20220726.1 |
MattGal
approved these changes
Jul 27, 2022
Contributor
|
Fallout from this: #10172 |
garath
added a commit
that referenced
this pull request
Jul 28, 2022
Arcade-validation build [20220727.18](https://dev.azure.com/dnceng/internal/_build/results?buildId=1908410&view=results) failed because changes #10141 mean more `SDLValidationParameters` in `post-build.yml` need explicit defaults set (the parameters-as-an-object method does not allow template defaults to come into play). This fixes that by setting an explicit default for `sdlContinueOnError`. This should be the only parameter affected as the others are checked for the "null or empty" value. Fixes #10172.
garath
added a commit
to garath/dotnet-arcade
that referenced
this pull request
Jul 28, 2022
This reverts commit 3fdfc33.
garath
added a commit
that referenced
this pull request
Jul 28, 2022
Arcade-services build [20220728.10](https://dev.azure.com/dnceng/internal/_build/results?buildId=1910254&view=results) shows that the fix from #10179 is incomplete. Reverting the whole effort for now; I'll debug this outside of main. Resolves #10193 * Revert "Update Guardian to Latest! Part Deux (#10141)" 3fdfc33. * Revert "Set default value for sdlContinueOnError (#10181)" This reverts commit c2faa9f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-apply #10065, with a fix to not incorrectly apply the
-Versionflag.Resolves #8075.