Add references to newtonsoft.json for transitive version pinning#10126
Merged
AlitzelMendez merged 2 commits intodotnet:mainfrom Jul 25, 2022
Merged
Add references to newtonsoft.json for transitive version pinning#10126AlitzelMendez merged 2 commits intodotnet:mainfrom
AlitzelMendez merged 2 commits intodotnet:mainfrom
Conversation
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
Contributor
Author
|
latest test build is finding some references to |
Contributor
Author
|
I think the last few references are coming from the test sdk. There's a newer version uploaded to solve their own newtonsoft dependency issues: https://www.nuget.org/packages/Microsoft.NET.Test.Sdk/17.4.0-preview-20220707-01#dependencies-body-tab Upgrading from our current version means we'll have to update some other dependencies, (or make sure to add newtonsoft references to every test project in the repo) so that might be better left as a separate PR. |
MattGal
approved these changes
Jul 25, 2022
Member
MattGal
left a comment
MattGal
left a comment
There was a problem hiding this comment.
LGTM, I assume you've built locally and checked out the package cache too?
Member
|
I talked with Ricardo and I am going to merge this pr to handle the other alerts in other pr |
am11
pushed a commit
to am11/arcade
that referenced
this pull request
Jul 26, 2022
…net#10126) * Add references to newtonsoft.json for transitive version pinning * but wait.. there's more
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #10101
Adds references to newtonsoft.json everywhere we need to control transitive pinning.
Running https://dev.azure.com/dnceng/internal/_build/results?buildId=1898566&view=results to see what CG thinks of these changes and whether they are enough.
A lot of the older versions we get through msbuild, which seems like too big of a dependency to just update everywhere, which makes me think the direct references are the best way to go to get this sorted.
To double check: