Skip to content

Ensure build task projects work when source built #7413

New issue
New issue
Closed
Closed
Ensure build task projects work when source built#7413
Assignees
mmitche
@JunTaoLuo

Description

@JunTaoLuo
JunTaoLuo
opened on May 19, 2021
  • This issue is blocking: source build

There are hardcoded paths in build tasks:

arcade/src/Microsoft.DotNet.Build.Tasks.Feed/build/Microsoft.DotNet.Build.Tasks.Feed.targets

Line 46 in 0b0d5b9

<_MicrosoftDotNetBuildTasksFeedTaskDir Condition="'$(MSBuildRuntimeType)' == 'Core'">$(MSBuildThisFileDirectory)../tools/netcoreapp3.1/</_MicrosoftDotNetBuildTasksFeedTaskDir>

This breaks in source built packages where the TFM is different:

arcade/eng/TargetFrameworkDefaults.props

Line 9 in e7ede87

<TargetFrameworkForNETSDK Condition="'$(DotNetBuildFromSource)' == 'true'">net5.0</TargetFrameworkForNETSDK>

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions