This if block covers the whole method including PR creation, rather than only skipping the parts that detect earlier PRs, so trying to force PR creation makes the method do nothing:
|
if (!options.ForceCreate) |
It looks like this was a mistake in this refactor: dotnet/buildtools@91726ae.
It should look more like it did before: https://github.com/dotnet/buildtools/blob/4642e67685b9c21c4d5160ea7665843a48ed8155/src/Microsoft.DotNet.VersionTools/Automation/PullRequestCreator.cs#L60-L112
Thanks @mthalman for pointing this out. /cc @MichaelSimons
(I don't have fixing this on my backlog as of writing, I'm filing this to track the known issue. Anyone can pick it up.)
This if block covers the whole method including PR creation, rather than only skipping the parts that detect earlier PRs, so trying to force PR creation makes the method do nothing:
arcade/src/Microsoft.DotNet.VersionTools/lib/src/Automation/PullRequestCreator.cs
Line 81 in e1f099b
It looks like this was a mistake in this refactor: dotnet/buildtools@91726ae.
It should look more like it did before: https://github.com/dotnet/buildtools/blob/4642e67685b9c21c4d5160ea7665843a48ed8155/src/Microsoft.DotNet.VersionTools/Automation/PullRequestCreator.cs#L60-L112
Thanks @mthalman for pointing this out. /cc @MichaelSimons
(I don't have fixing this on my backlog as of writing, I'm filing this to track the known issue. Anyone can pick it up.)