Skip to content

Change Warning to Information in Azure Helper retry code. #2611

@MattGal

Description

@MattGal

https://github.com/dotnet/arcade/blob/master/src/Microsoft.DotNet.Build.Tasks.Feed/src/common/AzureHelper.cs#L244

                try
                {
                    using (var request = createRequest())
                        response = await client.SendAsync(request);
                }
                catch (Exception e)
                {
                    loggingHelper.LogWarningFromException(e, true);

                    // if this is the final iteration let the exception bubble up
                    if (retries + 1 == retryCount)
                        throw;
                }

Unfortunately there are lots of builds which have settings to treat warnings as errors, leading to this retry logic not being very helpful.

I recommend we make this a LogInformation() type call but with the string "warning" so folks don't think it's good that their build had to retry.

@chcosta FYI.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions