Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/arcade
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f99e2f9b8a
Choose a base ref
...
head repository: dotnet/arcade
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: bbafffba44
Choose a head ref
  • 4 commits
  • 7 files changed
  • 3 contributors

Commits on Aug 2, 2023

  1. [main] Update dependencies from dotnet/arcade dotnet/source-build-ext…

    …ernals (#13936)
    
    [main] Update dependencies from dotnet/arcade dotnet/source-build-externals
    dotnet-maestro[bot] authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    3addc5d View commit details
    Browse the repository at this point in the history
  2. Avoid alerting CG when an intermediate nupkg contains "vulnerable" de…

    …pendencies (#13935)
    
    * Avoid alerting CG when an intermediate nupkg contains "vulnerable" dependencies.
    This change resolves dotnet/source-build#3559.
    
    When a repo restores the source build intermediates and places them in the package cache, it's essentially populating a local nuget feed. This feed should as a set of packages that _may_ be used, but are not necessarily used. When a package is restored from this feed, it is extracted and appears in the package root. Component Detection, unfortunately, picks up any .nupkg file that exists under the source or artifacts directories, which picks up the local package cache, even if those packages are not used by the repo. This tends to generate noise for repos because of SBRP's contents.
    
    To fix this issue, we apply two changes:
    - Delete the intermediate nupkg's extracted location after populating cache - The PackageReferences used to obtain the source build intermediates populate the nuget package root. We then copy the nupkg contents (nupkgs themselves) into the package cache. At this point, the original extracted nupkg is of no use. Deleting it removes one location where CG may detect .nupkgs that are available, but not necessarily used, by the repo.
    - Use an explicit CG scanning step that excludes the package cache - Alter the source-build template to exclude the package cache (local feed).
    
    This leaves the nuget package root "cleaner" as it should contain only .nupkg files that are actually utilized by the repo, and detection will include only the packages that are actually used by the repo.
    
    * Attempt to remove one location where the nuget package cache path is constructed
    mmitche authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    769f8b1 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Configuration menu
    Copy the full SHA
    2b2cfc2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bbafffb View commit details
    Browse the repository at this point in the history
Loading