Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/arcade
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 474307e
Choose a base ref
...
head repository: dotnet/arcade
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0ec8dba
Choose a head ref
  • 14 commits
  • 88 files changed
  • 9 contributors

Commits on Aug 30, 2021

  1. [main] Update dependencies from dotnet/xharness dotnet/xliff-tasks do…

    …tnet/arcade (#7809)
    
    [main] Update dependencies from dotnet/xharness dotnet/xliff-tasks dotnet/arcade
    dotnet-maestro[bot] authored Aug 30, 2021
    Configuration menu
    Copy the full SHA
    e0260cb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9c86377 View commit details
    Browse the repository at this point in the history
  3. Update ArPow build to build with current TFM (#7674)

    * Update TFM to net6.0
    
    * Exclude test projects from source-build
    
    * Remove net472 TFM
    
    * Use property instead of hardcoded version
    
    * EscapeUriString is obsolete.  Change to EscapeDataString
    
    * Revert "EscapeUriString is obsolete.  Change to EscapeDataString"
    
    This reverts commit e38710b.
    
    * Add NoWarn for SYSLIB0013
    
    Don't warn on SYSLIB0013 - Uri.EscapeUriString() is obsolete.
    This is marked obsolete for net6.0 and changing it to
    Uri.EscapeDataString() changes behavior.  Ignore the warning.
    
    * Update build tasks to fully qualify base class
    
    Because of the update to net6, implicit namespace support
    is causing a conflict  when using Task as a base class.
    
    * Fix one too aggressive search/replace
    dseefeld authored Aug 30, 2021
    Configuration menu
    Copy the full SHA
    f478e09 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2021

  1. Configuration menu
    Copy the full SHA
    761d2e6 View commit details
    Browse the repository at this point in the history
  2. Update to SDK that understands NUGET_ENABLE_EXPERIMENTAL_HTTP_RETRY (#…

    …7814)
    
    Update to an SDK that understands NUGET_ENABLE_EXPERIMENTAL_HTTP_RETRY, and set some values in common entry points (validated in binlogs)
    
    Users who need these values set from non-arcade execution paths can set them globally via yaml or their own scripts.
    MattGal authored Aug 31, 2021
    Configuration menu
    Copy the full SHA
    ca8ebd3 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2021

  1. Configuration menu
    Copy the full SHA
    75af908 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4d1fbd8 View commit details
    Browse the repository at this point in the history
  3. [main] Update dependencies from dotnet/xliff-tasks dotnet/arcade mono…

    …/linker (#7816)
    
    [main] Update dependencies from dotnet/xliff-tasks dotnet/arcade mono/linker
    dotnet-maestro[bot] authored Sep 1, 2021
    Configuration menu
    Copy the full SHA
    b0aeac9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    923c95e View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2021

  1. [workloads] Add locks for parallel NuGet access (#7813)

    Android workload pack conversion has been failing intermittently:
    
        Generating package project: 'obj\Debug\src\msiPackage\x86\Microsoft.Android.Sdk.Windows\msi.csproj'
        convert.proj(72,5): error : One or more errors occurred.
        convert.proj(72,5): error : Failed to generate MSIs for workload packs.
    
        C:\Users\AzDevOps\.nuget\packages\wix\3.14.0-dotnet\tools\heat.exe dir obj\Debug\pkg\Microsoft.Android.Templates.31.0.100-rc.2.14 -cg CG_PackageContent -var var.SourceDir -ag -srd -sreg -dr InstallDir -o obj\Debug\src\msi\Microsoft.Android.Templates\31.0.100-rc.2.14\x64\PackageContent.wxs
        ##[error]light.exe(0,0): Error LGHT0001: The system cannot find the file specified. (Exception from HRESULT: 0x80070002)
        light.exe : error LGHT0001: The system cannot find the file specified. (Exception from HRESULT: 0x80070002) [C:\a\1\s\nuget-msi-convert\convert-v2\convert.proj]
    
          Exception Type: System.IO.FileNotFoundException
    
          Stack Trace:
             at Microsoft.Tools.WindowsInstallerXml.Cab.Interop.NativeMethods.CreateCabFinish(IntPtr contextHandle, IntPtr newCabNamesCallBackAddress)
             at Microsoft.Tools.WindowsInstallerXml.Cab.WixCreateCab.Complete(IntPtr newCabNamesCallBackAddress)
             at Microsoft.Tools.WindowsInstallerXml.CabinetBuilder.CreateCabinet(CabinetWorkItem cabinetWorkItem)
             at Microsoft.Tools.WindowsInstallerXml.CabinetBuilder.ProcessWorkItems()
    
    I've added a lock to attempt to synchronize some .nupkg file access that
    seemed to be problematic when executing asynchronously.
    pjcollins authored Sep 2, 2021
    Configuration menu
    Copy the full SHA
    7168d63 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eecf503 View commit details
    Browse the repository at this point in the history
  3. Update version (#7829)

    epananth authored Sep 2, 2021
    Configuration menu
    Copy the full SHA
    4002b72 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    00949c5 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2021

  1. Adding detection and retargeting of DOTNETHOME (#7785)

    * Adding detection and retargeting of DOTNETHOME
    
    When x64 is installed on non-x64 machine, place in an x64 subdirectory.
    
    * Remove test value of dotnet folder
    
    * Fix ProgramFilesFolder preprocessor variable usage
    
    * Refactor Set_DOTNETHOME_x64 into a single shared source file
    
    * Add CA ID for INSTALLING_IN_EMULATION.
    
    * Define Platform consistently
    
    * Move workload registration to platform specific
    
    * Refactor INSTALLING_IN_EMULATION property
    
    Don't need to use a registry search since environment of the MSIServer
    process can be read (TBD pending reccomendation from MSI team).
    
    Also make property work for any architecture, in case we wish to use
    it more generically (EG: to condition PATH entry in host installer).
    
    * Make platform comparison case insensitive
    
    * Respond to feedback
    ericstj authored Sep 3, 2021
    Configuration menu
    Copy the full SHA
    0ec8dba View commit details
    Browse the repository at this point in the history
Loading