-
Notifications
You must be signed in to change notification settings - Fork 378
Comparing changes
Open a pull request
base repository: dotnet/arcade
base: 12b42d0
head repository: dotnet/arcade
compare: 1b04d6d
- 8 commits
- 8 files changed
- 7 contributors
Commits on Jan 13, 2023
-
Begin removal of MicrosoftSourceLinkVersion (#12197)
This property is a proxy for the versions of the source link packages. Proxy properties do not generally play well with source build. Source build must explictly set this property to be equal to the version of one of the other packages (GitHub or AzureRepos.Git) in order to properly override sourcelink to the incoming version. Fixing this will happen in three stages: - This PR: Change internal package references to reference the dependency flow properties for each individual package (GitHub and AzureRepos.Git). Add these properties to the generated sdk versions. Retain the original property name, but set it off of the GitHub package version. - Future PRs: Remove usages of MicrosoftSourceLinkVersion in repos. Where this property is used in repos, instead use the correct individual properties. - Final PR: Remove MicrosoftSourceLinkVersion. Some repos today set MicrosoftSourceLinkVersion (usually to an ancient version) but do not use it. This overrides Arcade's version. I believe most of these cases are in error, where repo owners expected dependency flow, but are not getting it. In these cases, this change will transparently upgrade them to Arcade's default.
Configuration menu - View commit details
-
Copy full SHA for f684cee - Browse repository at this point
Copy the full SHA f684ceeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 052e1f6 - Browse repository at this point
Copy the full SHA 052e1f6View commit details -
Update dependencies from https://github.com/dotnet/sourcelink build 2…
…0230112.2 (#12207) Microsoft.SourceLink.AzureRepos.Git , Microsoft.SourceLink.GitHub From Version 1.2.0-beta-23061-01 -> To Version 1.2.0-beta-23062-02 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 2bd64ae - Browse repository at this point
Copy the full SHA 2bd64aeView commit details -
Fix DefaultVersions.Generated.props syntax (#12208)
Regressed with f684cee
Configuration menu - View commit details
-
Copy full SHA for 3f370c7 - Browse repository at this point
Copy the full SHA 3f370c7View commit details -
Revert 12191 revert 12144 feature/numa (#12205)
* Revert "Revert "Install numa package in rootfs (#12144)" (#12191)" This reverts commit 12b42d0. * Erase numactl-dev from Alpine 3.13 arm * Fix shellcheck warning about string replacement https://www.shellcheck.net/wiki/SC2001 * Add version check * Simplify
Configuration menu - View commit details
-
Copy full SHA for cf1dc04 - Browse repository at this point
Copy the full SHA cf1dc04View commit details -
Configuration menu - View commit details
-
Copy full SHA for e151457 - Browse repository at this point
Copy the full SHA e151457View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c09760 - Browse repository at this point
Copy the full SHA 8c09760View commit details
Commits on Jan 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1b04d6d - Browse repository at this point
Copy the full SHA 1b04d6dView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 12b42d0...1b04d6d