Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/arcade
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 12b42d0
Choose a base ref
...
head repository: dotnet/arcade
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1b04d6d
Choose a head ref
  • 8 commits
  • 8 files changed
  • 7 contributors

Commits on Jan 13, 2023

  1. Begin removal of MicrosoftSourceLinkVersion (#12197)

    This property is a proxy for the versions of the source link packages. Proxy properties do not generally play well with source build. Source build must explictly set this property to be equal to the version of one of the other packages (GitHub or AzureRepos.Git) in order to properly override sourcelink to the incoming version.
    
    Fixing this will happen in three stages:
    - This PR: Change internal package references to reference the dependency flow properties for each individual package (GitHub and AzureRepos.Git). Add these properties to the generated sdk versions. Retain the original property name, but set it off of the GitHub package version.
    - Future PRs: Remove usages of MicrosoftSourceLinkVersion in repos. Where this property is used in repos, instead use the correct individual properties.
    - Final PR: Remove MicrosoftSourceLinkVersion.
    
    Some repos today set MicrosoftSourceLinkVersion (usually to an ancient version) but do not use it. This overrides Arcade's version. I believe most of these cases are in error, where repo owners expected dependency flow, but are not getting it. In these cases, this change will transparently upgrade them to Arcade's default.
    mmitche authored Jan 13, 2023
    Configuration menu
    Copy the full SHA
    f684cee View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    052e1f6 View commit details
    Browse the repository at this point in the history
  3. Update dependencies from https://github.com/dotnet/sourcelink build 2…

    …0230112.2 (#12207)
    
    Microsoft.SourceLink.AzureRepos.Git , Microsoft.SourceLink.GitHub
     From Version 1.2.0-beta-23061-01 -> To Version 1.2.0-beta-23062-02
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    dotnet-maestro[bot] and dotnet-maestro[bot] authored Jan 13, 2023
    Configuration menu
    Copy the full SHA
    2bd64ae View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3f370c7 View commit details
    Browse the repository at this point in the history
  5. Revert 12191 revert 12144 feature/numa (#12205)

    * Revert "Revert "Install numa package in rootfs (#12144)" (#12191)"
    
    This reverts commit 12b42d0.
    
    * Erase numactl-dev from Alpine 3.13 arm
    
    * Fix shellcheck warning about string replacement
    https://www.shellcheck.net/wiki/SC2001
    
    * Add version check
    
    * Simplify
    am11 authored Jan 13, 2023
    Configuration menu
    Copy the full SHA
    cf1dc04 View commit details
    Browse the repository at this point in the history
  6. [main] Update dependencies from dotnet/xliff-tasks dotnet/arcade (#12209

    )
    
    [main] Update dependencies from dotnet/xliff-tasks dotnet/arcade
    dotnet-maestro[bot] authored Jan 13, 2023
    Configuration menu
    Copy the full SHA
    e151457 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8c09760 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2023

  1. Configuration menu
    Copy the full SHA
    1b04d6d View commit details
    Browse the repository at this point in the history
Loading