Add extra logging to DownloadFile after all retries fail (#14147)

lewing · web-flow · commit 025a2b3851db · 2023-10-20T21:39:09.000Z
diff --git a/src/Microsoft.DotNet.Arcade.Sdk/src/DownloadFile.cs b/src/Microsoft.DotNet.Arcade.Sdk/src/DownloadFile.cs
@@ -183,6 +183,7 @@ private async Tasks.Task<bool> DownloadWithRetriesAsync(HttpClient httpClient, s
                     }
 
                     Log.LogMessage($"Retrying download of '{uri}' to '{DestinationPath}' due to failure: '{e.Message}' ({attempt}/{Retries})");
+                    Log.LogErrorFromException(e, true, true, null);
 
                     await Tasks.Task.Delay(RetryDelayMilliseconds).ConfigureAwait(false);
                     continue;

Original file line number	Diff line number	Diff line change
`@@ -183,6 +183,7 @@ private async Tasks.Task<bool> DownloadWithRetriesAsync(HttpClient httpClient, s`
`183`	`183`	`}`
`184`	`184`
`185`	`185`	`Log.LogMessage($"Retrying download of '{uri}' to '{DestinationPath}' due to failure: '{e.Message}' ({attempt}/{Retries})");`
	`186`	`+ Log.LogErrorFromException(e, true, true, null);`
`186`	`187`
`187`	`188`	`await Tasks.Task.Delay(RetryDelayMilliseconds).ConfigureAwait(false);`
`188`	`189`	`continue;`