Fix more <para> cases#173
Merged
carlossanlop merged 3 commits intodotnet:mainfrom Aug 15, 2024
carlossanlop:FixParaNewLines
Merged
Fix more <para> cases#173carlossanlop merged 3 commits intodotnet:mainfrom carlossanlop:FixParaNewLines
carlossanlop merged 3 commits intodotnet:mainfrom
carlossanlop:FixParaNewLines
Conversation
- Join paragraphs separated by newlines. - Split paragraphs that end in "." or ":". - Treat "-or-" and "- or -" as their own paragraphs. - Make sure single paragraphs are not wrapped. - Make sure empty newlines are ignored.
gewarren
approved these changes
Aug 15, 2024
Member
|
Amazing, thanks! It would interesting to see if we could retroactively fix up some of the docs that were already ported using the old logic. A regex detecting single-line |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the logic that wraps paragraphs with
<para></para>:I'd appreciate a review from the folks who noticed the noisy
<para>when porting, @eiriktsarpalis @jozkee @gewarren @lonitra