Code that runs in VS needs to target either net46 or net472 in dev16+ #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it fully compatible with NS2. Otherwise, an SDK targeting pack needs to be installed and a whole bunch of facade assemblies are included as part of the build which aren't needed and can cause issues when running inside the IDE.
Contributor
Author
|
@kdubau could you help me get this green on mac? thanks! |
kzu
changed the title
Under VS2017+, code must either target net46 or net472 and nothing in between. Otherwise, run-time errors might happen if the wrong assemblies (facades for NS2 support) are inadvertently bound at compile time and loaded at run-time.
jonathanpeppers
approved these changes
Jun 4, 2019
Contributor
Author
|
@monokenkins backport to d16-2 |
kzu
added a commit
that referenced
this pull request
Jun 4, 2019
Under VS2017+, code must either target net46 or net472 and nothing in between. Otherwise, run-time errors might happen if the wrong assemblies (facades for NS2 support) are inadvertently bound at compile time and loaded at run-time.
kzu
added a commit
that referenced
this pull request
Jun 4, 2019
Under VS2017+, code must either target net46 or net472 and nothing in between. Otherwise, run-time errors might happen if the wrong assemblies (facades for NS2 support) are inadvertently bound at compile time and loaded at run-time.
kzu
added a commit
that referenced
this pull request
Jun 4, 2019
Under VS2017+, code must either target net46 or net472 and nothing in between. Otherwise, run-time errors might happen if the wrong assemblies (facades for NS2 support) are inadvertently bound at compile time and loaded at run-time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it fully compatible with NS2. Otherwise, an SDK targeting pack needs to be installed and
a whole bunch of facade assemblies are included as part of the build which aren't needed and can
cause issues when running inside the IDE.
Fixes AB#905023