Remove hardcoded Path #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context https://dev.azure.com/devdiv/DevDiv/_workitems/edit/2341994 Remove the hardcoded path to `C:\android-sdk-windows` from the list of backup paths to check when scanning for the android sdk.
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jonathanpeppers
approved these changes
Jan 14, 2025
pjcollins
approved these changes
Jan 14, 2025
Contributor
|
That path was first added in 2012: https://github.com/xamarin/androidtools/commit/94e46bcc818b287a659ff8cd0d4c0ab83c80255b No explanation for why that path was added… |
jonpryor
pushed a commit
that referenced
this pull request
Jan 14, 2025
Context: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/2341994 Context: https://github.com/xamarin/androidtools/commit/94e46bcc818b287a659ff8cd0d4c0ab83c80255b Remove the hardcoded path `C:\android-sdk-windows` from the list of backup paths to check when scanning for the Android SDK. This path was first added in xamarin/androidtools@94e46bcc, with no explanation for *why* that was the backup path. Perhaps that was the convention at the time?
jonpryor
pushed a commit
that referenced
this pull request
Jan 14, 2025
Context: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/2341994 Context: https://github.com/xamarin/androidtools/commit/94e46bcc818b287a659ff8cd0d4c0ab83c80255b Remove the hardcoded path `C:\android-sdk-windows` from the list of backup paths to check when scanning for the Android SDK. This path was first added in xamarin/androidtools@94e46bcc, with no explanation for *why* that was the backup path. Perhaps that was the convention at the time?
jonpryor
pushed a commit
to dotnet/java-interop
that referenced
this pull request
Jan 19, 2025
Changes: dotnet/android-tools@f62cd09...36e574c * dotnet/android-tools@36e574c: [Xamarin.Android.Tools.AndroidSdk] Remove hardcoded Path (dotnet/android-tools#248) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
pjcollins
pushed a commit
that referenced
this pull request
Feb 20, 2025
Context: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/2341994 Context: xamarin/androidtools@94e46bc Remove the hardcoded path `C:\android-sdk-windows` from the list of backup paths to check when scanning for the Android SDK. This path was first added in xamarin/androidtools@94e46bcc, with no explanation for *why* that was the backup path. Perhaps that was the convention at the time?
jonpryor
added a commit
to dotnet/android
that referenced
this pull request
Mar 21, 2025
Changes: dotnet/android-tools@f53106a...5612c1a * dotnet/android-tools@5612c1a: [Xamarin.Android.Tools.AndroidSdk] OS-specific dirs are OS-specific (dotnet/android-tools#250) * dotnet/android-tools@da87185: [Xamarin.Android.Tools.AndroidSdk] Remove hardcoded Path (dotnet/android-tools#248)
pjcollins
pushed a commit
to dotnet/android
that referenced
this pull request
Mar 21, 2025
Changes: dotnet/android-tools@f53106a...5612c1a * dotnet/android-tools@5612c1a: [Xamarin.Android.Tools.AndroidSdk] OS-specific dirs are OS-specific (dotnet/android-tools#250) * dotnet/android-tools@da87185: [Xamarin.Android.Tools.AndroidSdk] Remove hardcoded Path (dotnet/android-tools#248)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context https://dev.azure.com/devdiv/DevDiv/_workitems/edit/2341994
Remove the hardcoded path to
C:\android-sdk-windowsfrom the list of backup paths to check when scanning for the android sdk.