Adding condition to GetFilesToSign #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…figuration is Release
pjcollins
approved these changes
Feb 4, 2022
thsparks
pushed a commit
that referenced
this pull request
Mar 21, 2022
Adding condition to GetFilesToSign
thsparks
pushed a commit
that referenced
this pull request
Apr 18, 2022
Adding condition to GetFilesToSign
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding condition to GetFilesToSign to only include files if build configuration is Release.
This change is to support signing in the Android.SDK.Manager build pipeline. A condition was added for the signing ItemGroup to only create it if the
$(Configuration)is a Release configuration. This is to handle the case where a solution file might build a debug configuration in a real sign build. The debug configuration will ignore the signing ItemGroup.